-
-
Notifications
You must be signed in to change notification settings - Fork 896
chore: update meetings.json and newsrooom_videos.json #3935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #3935
Conversation
WalkthroughThe changes update the dashboard configuration by adding new entries, modifying an existing one with updated titles, resource paths, and repositories, and removing outdated content. Additionally, several score values and labels across multiple entries have been revised, reflecting the current priority and categorization of contributions. Changes
Sequence Diagram(s):Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3935 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 667 667
Branches 113 113
=========================================
Hits 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
dashboard.json (4)
55-56
: Score Field Update Confirmation
The score for the "docs: add Bounty Program Rules" entry is now set to 22.68679251119144. Please verify that this updated value fits the intended ranking compared to other entries.
79-93
: Updated Website Redesign Entry
The "Redesign the AsyncAPI Website and Implement Dark Theme" entry now has its score updated to 16.943300736206268. Double-check that this value reflects the current prioritization for design issues.
95-105
: Finance Data Viewing Entry Review
The entry for "feat: enabled viewing historical finance data" shows an updated score equal to that of the design-themed entry. Please verify that the identical scoring is intentional given the context and overall ranking logic.
129-151
: Holopin Design Tracking Score Adjustment
The score for the "[DESIGN] Holopin Design Tracking" entry is updated to 15.794602381209232. Confirm that this revised value is in line with the new prioritization criteria for design-related issues.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
dashboard.json
(5 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (5)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
🔇 Additional comments (7)
dashboard.json (7)
57-67
: Addition of New PR Entry
A new entry for the ROS2 AsyncAPI contribution by SIEMENS AG appears correctly formed with all required fields. The numeric score and data values look consistent.
68-78
: Verify Blog Entry Redundancy
The entry with ID"PR_kwDOBW5R_c6MO2j-"
titled "chore(blog): add ashmit spotlight story" is present here. Note that according to the high-level summary, this entry was meant to be modified into the student ambassador entry. Please confirm whether both entries are intended to coexist or if the former should be replaced.
117-127
: Modified Blog Entry Replacement
The entry with ID"PR_kwDOFLhIt853IEwA"
now presents a new title "docs: added asyncapi student ambassador md file", a new resource path, and repo. Ensure that this modified entry correctly replaces or distinguishes itself from the earlier blog entry (ID"PR_kwDOBW5R_c6MO2j-"
) to avoid any redundancy in the dashboard.
153-171
: Review of 'Please support File References' Entry
This entry is updated with"isAssigned": true
and a new score of 14.07155484871368. Please verify whether keeping an assigned status on this issue (which appears to be an older or possibly deprecated request) is intended under the current dashboard guidelines.
172-195
: New Governance Automation Entry Addition
The new entry for "Automatepaper work
around project governance" has been added with all necessary details (author, resource path, labels, and score). The structure and field values are consistent with the rest of the file.
199-207
: New Good First Issue Entry Added
The issue "[Improvement]: Improve the error message while generating project fromgenerate command" is added in thegoodFirstIssues
section. It is clear and contains the required fields.
208-217
: New Interactive Command Issue Entry
The entry "[Improvement]: Make the steps of Asyncapi start studio command interactive" is also added in thegoodFirstIssues
section. Confirm that the assignment flag ("isAssigned": true
) is intentional for this improvement task.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Documentation
Bug Fixes
Chores